Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Fluff Things #283

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

More Fluff Things #283

wants to merge 14 commits into from
+58 −59

Conversation

KoishiVibe
Copy link
Contributor

@KoishiVibe KoishiVibe commented Jun 6, 2024 •
edited
Loading

Summary

  • M240A1 is now M240. This has been bothering me for a while how can you tell?
  • M240-T is now M240E1.
  • XM88 is now the XM88A. Should be nominally more in line with other armat weapons?
  • ammo for it has been modified to be something more in line with other inuniverse calibers, such as .458 socom now becoming a 10mm variety.

@DexterDude
Copy link
Contributor

can you provide lore reasoning

@DexterDude
Copy link
Contributor

also, undocumented changes (random bullet name changes)

@KoishiVibe
Copy link
Contributor Author

also, undocumented changes (random bullet name changes)

oh right i was gonna update after I added those but forgor.

@KoishiVibe KoishiVibe marked this pull request as ready for review June 22, 2024 06:36
Doubleumc
Doubleumc requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the undocumented changes to the M42A.

Otherwise, looks good to me.

@Doubleumc
Copy link
Contributor

Feel free to reopen when the issues have been addressed.

@Doubleumc Doubleumc marked this pull request as draft August 15, 2024 05:31
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doubleumc Doubleumc Doubleumc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Merge Conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KoishiVibe @DexterDude @Doubleumc @cm13-github